Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b632ffa7 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Doug Ledford
Browse files

IB/uverbs: reject invalid or unknown opcodes 



We have many WR opcodes that are only supported in kernel space
and/or require optional information to be copied into the WR
structure.  Reject all those not explicitly handled so that we
can't pass invalid information to drivers.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Reviewed-by: default avatarSagi Grimberg <sagig@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 54b9a96f

drivers/infiniband/core/uverbs_cmd.c

+9 −1
Original line number Diff line number Diff line
@@ -2372,6 +2372,12 @@ ssize_t ib_uverbs_post_send(struct ib_uverbs_file *file, 
		next->send_flags = user_wr->send_flags;



		if (is_ud) {

			if (next->opcode != IB_WR_SEND &&

			    next->opcode != IB_WR_SEND_WITH_IMM) {

				ret = -EINVAL;

				goto out_put;

			}



			next->wr.ud.ah = idr_read_ah(user_wr->wr.ud.ah,

						     file->ucontext);

			if (!next->wr.ud.ah) {
@@ -2411,9 +2417,11 @@ ssize_t ib_uverbs_post_send(struct ib_uverbs_file *file, 
					user_wr->wr.atomic.compare_add;

				next->wr.atomic.swap = user_wr->wr.atomic.swap;

				next->wr.atomic.rkey = user_wr->wr.atomic.rkey;

			case IB_WR_SEND:

				break;

			default:

				break;

				ret = -EINVAL;

				goto out_put;

			}

		}