Commit 54b9a96f authored Aug 26, 2015 by Nicholas Krause Committed by Doug Ledford Sep 03, 2015

IB/cxgb4: Fix if statement in pick_local_ip6adddrs



This fixes an if statement checking the return value of the function
get_lladdr for success in the function pick_local_ip6addrs to instead
of directly checking the return value of this call check the opposite
as get_lladdr returns zero for success which would incorrectly make
this if statement block not execute with the current if statement
check.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent ba13b5f8

drivers/infiniband/hw/cxgb4/cm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3031,7 +3031,7 @@ static int pick_local_ip6addrs(struct c4iw_dev dev, struct iw_cm_id cm_id)
		struct sockaddr_in6 la6 = (struct sockaddr_in6 )&cm_id->local_addr;
		struct sockaddr_in6 ra6 = (struct sockaddr_in6 )&cm_id->remote_addr;

		if (get_lladdr(dev->rdev.lldi.ports[0], &addr, IFA_F_TENTATIVE)) {
		if (!get_lladdr(dev->rdev.lldi.ports[0], &addr, IFA_F_TENTATIVE)) {
		memcpy(la6->sin6_addr.s6_addr, &addr, 16);
		memcpy(ra6->sin6_addr.s6_addr, &addr, 16);
		return 0;