Commit b467e08a authored Mar 18, 2017 by Icenowy Zheng Committed by Maxime Ripard Mar 20, 2017

clk: sunxi-ng: fix recalc_rate formula of NKMP clocks

In commit e66f81bb ("clk: sunxi-ng: Implement factors offsets"), the
final formula of NKMP clocks' recalc_rate is refactored; however, the
refactored formula broke the calculation due to some C language operand
priority problem -- the priority of operand >> is lower than * and /,
makes the formula being parsed as "(parent_rate * n * k) >> (p / m)", but
it should be "(parent_rate * n * k >> p) / m".

Add the pair of parentheses to fix up this issue. This pair of
parentheses used to exist in the old formula.

Fixes: e66f81bb ("clk: sunxi-ng: Implement factors offsets")
Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

parent fe686bab

drivers/clk/sunxi-ng/ccu_nkmp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -107,7 +107,7 @@ static unsigned long ccu_nkmp_recalc_rate(struct clk_hw *hw,
		p = reg >> nkmp->p.shift;
		p &= (1 << nkmp->p.width) - 1;

		return parent_rate * n * k >> p / m;
		return (parent_rate * n * k >> p) / m;
		}

		static long ccu_nkmp_round_rate(struct clk_hw *hw, unsigned long rate,