Commit adb31be4 authored May 22, 2018 by Roman Gushchin Committed by Shuah Khan (Samsung OSG) May 30, 2018

kselftest/cgroup: fix variable dereferenced before check warning



cg_name(const char *root, const char *name) is always called with
non-empty root and name arguments, so there is no sense in checking
it in the function body (after using in strlen()).

Signed-off-by: Roman Gushchin <guro@fb.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>

parent 7b04d1e9

tools/testing/selftests/cgroup/cgroup_util.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -59,7 +59,6 @@ char cg_name(const char root, const char *name)
		size_t len = strlen(root) + strlen(name) + 2;
		char *ret = malloc(len);

		if (name)
		snprintf(ret, len, "%s/%s", root, name);

		return ret;
		@@ -70,7 +69,6 @@ char cg_name_indexed(const char root, const char *name, int index)
		size_t len = strlen(root) + strlen(name) + 10;
		char *ret = malloc(len);

		if (name)
		snprintf(ret, len, "%s/%s_%d", root, name, index);

		return ret;