Commit aa5754c7 authored Oct 14, 2017 by Wolfram Sang Committed by Ulf Hansson Oct 30, 2017

mmc: meson-mx-sdio: catch all errors when getting regulators

Bail out everytime when mmc_regulator_get_supply() returns an errno, not
only when probing gets deferred. This is currently a no-op, because this
function only returns -EPROBE_DEFER or 0 right now. But if it will throw
another error somewhen, it will be for a reason. (This still doesn't change
that getting regulators is optional, so 0 can still mean no regulators
found). So, let us a) be future proof and b) have driver code which is
easier to understand.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent fa54f3e3

drivers/mmc/host/meson-mx-sdio.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -551,7 +551,7 @@ static int meson_mx_mmc_add_host(struct meson_mx_mmc_host *host)

	/* Get regulators and the supported OCR mask */		/* Get regulators and the supported OCR mask */
	ret = mmc_regulator_get_supply(mmc);		ret = mmc_regulator_get_supply(mmc);
	if (ret == -EPROBE_DEFER)		if (ret)
	return ret;		return ret;

	mmc->max_req_size = MESON_MX_SDIO_BOUNCE_REQ_SIZE;		mmc->max_req_size = MESON_MX_SDIO_BOUNCE_REQ_SIZE;