Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa54f3e3 authored by Wolfram Sang's avatar Wolfram Sang Committed by Ulf Hansson
Browse files

mmc: meson-gx-mmc: catch all errors when getting regulators 



Bail out everytime when mmc_regulator_get_supply() returns an errno, not
only when probing gets deferred. This is currently a no-op, because this
function only returns -EPROBE_DEFER or 0 right now. But if it will throw
another error somewhen, it will be for a reason. (This still doesn't change
that getting regulators is optional, so 0 can still mean no regulators
found). So, let us a) be future proof and b) have driver code which is
easier to understand.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 0f3a47b8

drivers/mmc/host/meson-gx-mmc.c

+1 −1
Original line number Diff line number Diff line
@@ -1190,7 +1190,7 @@ static int meson_mmc_probe(struct platform_device *pdev) 
	/* Get regulators and the supported OCR mask */

	host->vqmmc_enabled = false;

	ret = mmc_regulator_get_supply(mmc);

	if (ret == -EPROBE_DEFER)

	if (ret)

		goto free_host;



	ret = mmc_of_parse(mmc);