Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a446c998 authored by Miquel Raynal's avatar Miquel Raynal Committed by Boris Brezillon
Browse files

mtd: rawnand: cafe: fix probe function error path 



An error after nand_scan_tail() should trigger a nand_cleanup().
The helper mtd_device_parse_register() returns an error code that should
be checked and nand_cleanup() called accordingly.

Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@bootlin.com>
parent 5826b880

drivers/mtd/nand/raw/cafe_nand.c

+5 −1
Original line number Diff line number Diff line
@@ -774,10 +774,14 @@ static int cafe_nand_probe(struct pci_dev *pdev, 
	pci_set_drvdata(pdev, mtd);



	mtd->name = "cafe_nand";

	mtd_device_parse_register(mtd, part_probes, NULL, NULL, 0);

	err = mtd_device_parse_register(mtd, part_probes, NULL, NULL, 0);

	if (err)

		goto out_cleanup_nand;



	goto out;



 out_cleanup_nand:

	nand_cleanup(&cafe->nand);

 out_free_dma:

	dma_free_coherent(&cafe->pdev->dev, 2112, cafe->dmabuf, cafe->dmaaddr);

 out_irq: