Commit a3e968b6 authored Jun 07, 2021 by Yang Li Committed by Greg Kroah-Hartman Sep 22, 2021

NTB: perf: Fix an error code in perf_setup_inbuf()



[ Upstream commit 0097ae5f7af5684f961a5f803ff7ad3e6f933668 ]

When the function IS_ALIGNED() returns false, the value of ret is 0.
So, we set ret to -EINVAL to indicate this error.

Clean up smatch warning:
drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error
code 'ret'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 86e6540a

drivers/ntb/test/ntb_perf.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -600,6 +600,7 @@ static int perf_setup_inbuf(struct perf_peer *peer)
		return -ENOMEM;
		}
		if (!IS_ALIGNED(peer->inbuf_xlat, xlat_align)) {
		ret = -EINVAL;
		dev_err(&perf->ntb->dev, "Unaligned inbuf allocated\n");
		goto err_free_inbuf;
		}