Commit 86e6540a authored Sep 03, 2021 by Yang Li Committed by Greg Kroah-Hartman Sep 22, 2021

ethtool: Fix an error code in cxgb2.c



[ Upstream commit 7db8263a12155c7ae4ad97e850f1e499c73765fc ]

When adapter->registered_device_map is NULL, the value of err is
uncertain, we set err to -EINVAL to avoid ambiguity.

Clean up smatch warning:
drivers/net/ethernet/chelsio/cxgb/cxgb2.c:1114 init_one() warn: missing
error code 'err'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2c1b1848

drivers/net/ethernet/chelsio/cxgb/cxgb2.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1153,6 +1153,7 @@ static int init_one(struct pci_dev pdev, const struct pci_device_id ent)
		if (!adapter->registered_device_map) {
		pr_err("%s: could not register any net devices\n",
		pci_name(pdev));
		err = -EINVAL;
		goto out_release_adapter_res;
		}