Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cf29399 authored by Dave Airlie's avatar Dave Airlie Committed by Alex Deucher
Browse files

amdgpu/dc: make opp construct void. 



This doesn't return anything except true.

Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c60ae112

drivers/gpu/drm/amd/display/dc/dce/dce_opp.c

+1 −3
Original line number Diff line number Diff line
@@ -540,7 +540,7 @@ static const struct opp_funcs funcs = { 
	.opp_program_bit_depth_reduction = dce110_opp_program_bit_depth_reduction

};



bool dce110_opp_construct(struct dce110_opp *opp110,

void dce110_opp_construct(struct dce110_opp *opp110,

	struct dc_context *ctx,

	uint32_t inst,

	const struct dce_opp_registers *regs,
@@ -556,8 +556,6 @@ bool dce110_opp_construct(struct dce110_opp *opp110, 
	opp110->regs = regs;

	opp110->opp_shift = opp_shift;

	opp110->opp_mask = opp_mask;



	return true;

}



void dce110_opp_destroy(struct output_pixel_processor **opp)

drivers/gpu/drm/amd/display/dc/dce/dce_opp.h

+1 −1
Original line number Diff line number Diff line
@@ -272,7 +272,7 @@ struct dce110_opp { 
	const struct dce_opp_mask *opp_mask;

};



bool dce110_opp_construct(struct dce110_opp *opp110,

void dce110_opp_construct(struct dce110_opp *opp110,

	struct dc_context *ctx,

	uint32_t inst,

	const struct dce_opp_registers *regs,

drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c

+3 −7
Original line number Diff line number Diff line
@@ -547,13 +547,9 @@ struct output_pixel_processor *dce100_opp_create( 
	if (!opp)

		return NULL;



	if (dce110_opp_construct(opp,

			ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask))

	dce110_opp_construct(opp,

			     ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask);

	return &opp->base;



	BREAK_TO_DEBUGGER();

	kfree(opp);

	return NULL;

}



struct clock_source *dce100_clock_source_create(

drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c

+3 −7
Original line number Diff line number Diff line
@@ -586,13 +586,9 @@ static struct output_pixel_processor *dce110_opp_create( 
	if (!opp)

		return NULL;



	if (dce110_opp_construct(opp,

				ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask))

	dce110_opp_construct(opp,

			     ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask);

	return &opp->base;



	BREAK_TO_DEBUGGER();

	kfree(opp);

	return NULL;

}



struct clock_source *dce110_clock_source_create(

drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c

+3 −7
Original line number Diff line number Diff line
@@ -586,13 +586,9 @@ struct output_pixel_processor *dce112_opp_create( 
	if (!opp)

		return NULL;



	if (dce110_opp_construct(opp,

			ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask))

	dce110_opp_construct(opp,

			     ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask);

	return &opp->base;



	BREAK_TO_DEBUGGER();

	kfree(opp);

	return NULL;

}



struct clock_source *dce112_clock_source_create(