Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c60ae112 authored by Dave Airlie's avatar Dave Airlie Committed by Alex Deucher
Browse files

amdgpu/dc: make link encoder construct void.



This only ever returned true.

Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent f29f918f
Loading
Loading
Loading
Loading
+1 −3
Original line number Diff line number Diff line
@@ -914,7 +914,7 @@ bool dce110_link_encoder_validate_dp_output(
	return false;
}

bool dce110_link_encoder_construct(
void dce110_link_encoder_construct(
	struct dce110_link_encoder *enc110,
	const struct encoder_init_data *init_data,
	const struct encoder_feature_support *enc_features,
@@ -1013,8 +1013,6 @@ bool dce110_link_encoder_construct(
				bp_cap_info.DP_HBR3_EN;
		enc110->base.features.flags.bits.HDMI_6GB_EN = bp_cap_info.HDMI_6GB_EN;
	}

	return true;
}

bool dce110_link_encoder_validate_output_with_stream(
+1 −1
Original line number Diff line number Diff line
@@ -168,7 +168,7 @@ struct dce110_link_encoder {
};


bool dce110_link_encoder_construct(
void dce110_link_encoder_construct(
	struct dce110_link_encoder *enc110,
	const struct encoder_init_data *init_data,
	const struct encoder_feature_support *enc_features,
+7 −14
Original line number Diff line number Diff line
@@ -528,22 +528,15 @@ struct link_encoder *dce100_link_encoder_create(
	if (!enc110)
		return NULL;

	if (dce110_link_encoder_construct(
			enc110,
	dce110_link_encoder_construct(enc110,
				      enc_init_data,
				      &link_enc_feature,
				      &link_enc_regs[enc_init_data->transmitter],
				      &link_enc_aux_regs[enc_init_data->channel - 1],
			&link_enc_hpd_regs[enc_init_data->hpd_source])) {

				      &link_enc_hpd_regs[enc_init_data->hpd_source]);
	return &enc110->base;
}

	BREAK_TO_DEBUGGER();
	kfree(enc110);
	return NULL;
}

struct output_pixel_processor *dce100_opp_create(
	struct dc_context *ctx,
	uint32_t inst)
+7 −14
Original line number Diff line number Diff line
@@ -567,22 +567,15 @@ static struct link_encoder *dce110_link_encoder_create(
	if (!enc110)
		return NULL;

	if (dce110_link_encoder_construct(
			enc110,
	dce110_link_encoder_construct(enc110,
				      enc_init_data,
				      &link_enc_feature,
				      &link_enc_regs[enc_init_data->transmitter],
				      &link_enc_aux_regs[enc_init_data->channel - 1],
			&link_enc_hpd_regs[enc_init_data->hpd_source])) {

				      &link_enc_hpd_regs[enc_init_data->hpd_source]);
	return &enc110->base;
}

	BREAK_TO_DEBUGGER();
	kfree(enc110);
	return NULL;
}

static struct output_pixel_processor *dce110_opp_create(
	struct dc_context *ctx,
	uint32_t inst)
+7 −14
Original line number Diff line number Diff line
@@ -552,22 +552,15 @@ struct link_encoder *dce112_link_encoder_create(
	if (!enc110)
		return NULL;

	if (dce110_link_encoder_construct(
			enc110,
	dce110_link_encoder_construct(enc110,
				      enc_init_data,
				      &link_enc_feature,
				      &link_enc_regs[enc_init_data->transmitter],
				      &link_enc_aux_regs[enc_init_data->channel - 1],
			&link_enc_hpd_regs[enc_init_data->hpd_source])) {

				      &link_enc_hpd_regs[enc_init_data->hpd_source]);
	return &enc110->base;
}

	BREAK_TO_DEBUGGER();
	kfree(enc110);
	return NULL;
}

static struct input_pixel_processor *dce112_ipp_create(
	struct dc_context *ctx, uint32_t inst)
{
Loading