Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b0fa60d authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: add test for char * arrays that could be static const 



static const char* arrays create smaller text as each function call does
not have to populate the array.

Emit a warning when char *arrays aren't static const and the array is
not apparently global by being declared in the first column.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 447432f3

scripts/checkpatch.pl

+7 −0
Original line number Original line Diff line number Diff line
@@ -2675,6 +2675,13 @@ sub process { 
				$herecurr);

				$herecurr);

               }

               }





# check for non-global char *foo[] = {"bar", ...} declarations.

		if ($line =~ /^.\s+(?:static\s+|const\s+)?char\s+\*\s*\w+\s*\[\s*\]\s*=\s*\{/) {

			WARN("STATIC_CONST_CHAR_ARRAY",

			     "char * array declaration might be better as static const\n" .

				$herecurr);

               }



# check for function declarations without arguments like "int foo()"

# check for function declarations without arguments like "int foo()"

		if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) {

		if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) {

			if (ERROR("FUNCTION_WITHOUT_ARGS",

			if (ERROR("FUNCTION_WITHOUT_ARGS",