Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 447432f3 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: fix jiffies comparison and others 



checkpatch could not distinguish between a variable in a struct named
jiffies and the normal jiffies.

	foo->jiffies

would emit a "Comparing jiffies" arning.

Update the $Compare variable to do a negative look-behind for "-" when
finding a ">" so that a pointer dereference like -> isn't a comparison.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6c8bd707

scripts/checkpatch.pl

+1 −1
Original line number Diff line number Diff line
@@ -296,7 +296,7 @@ our $Float_int = qr{(?i)[0-9]+e-?[0-9]+[fl]?}; 
our $Float	= qr{$Float_hex|$Float_dec|$Float_int};

our $Constant	= qr{$Float|$Binary|$Octal|$Hex|$Int};

our $Assignment	= qr{\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=};

our $Compare    = qr{<=|>=|==|!=|<|>};

our $Compare    = qr{<=|>=|==|!=|<|(?<!-)>};

our $Arithmetic = qr{\+|-|\*|\/|%};

our $Operators	= qr{

			<=|>=|==|!=|