Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9144efff authored by sokchetra eung's avatar sokchetra eung Committed by Sridhar Gujje
Browse files

msm: camera: req_mgr: Table info dump removed 



Remove dump_tbl_info function and all of its
invocations in CRM to prevent dumping all the
handle info when holding the spin lock.

CRs-Fixed: 3014074, 3014073
Change-Id: Ie98bafb489fc0d1f2d75cf0f3f08efb48d9b4062
Signed-off-by: default avatarsokchetra eung <eung@codeaurora.org>
parent 0548e191

drivers/cam_req_mgr/cam_req_mgr_util.c

+2 −18
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/*

 * Copyright (c) 2017-2020, The Linux Foundation. All rights reserved.

 * Copyright (c) 2017-2021, The Linux Foundation. All rights reserved.

 */



#define pr_fmt(fmt) "CAM-REQ-MGR_UTIL %s:%d " fmt, __func__, __LINE__
@@ -114,7 +114,7 @@ static int32_t cam_get_free_handle_index(void) 
	idx = find_first_zero_bit(hdl_tbl->bitmap, hdl_tbl->bits);



	if (idx >= CAM_REQ_MGR_MAX_HANDLES_V2 || idx < 0) {

		CAM_DBG(CAM_CRM, "idx: %d", idx);

		CAM_ERR(CAM_CRM, "No free index found idx: %d", idx);

		return -ENOSR;

	}
@@ -123,20 +123,6 @@ static int32_t cam_get_free_handle_index(void) 
	return idx;

}



void cam_dump_tbl_info(void)

{

	int i;



	for (i = 0; i < CAM_REQ_MGR_MAX_HANDLES_V2; i++)

		CAM_INFO(CAM_CRM,

			"i: %d session_hdl=0x%x hdl_value=0x%x type=%d state=%d dev_id=0x%llx",

			i, hdl_tbl->hdl[i].session_hdl,

			hdl_tbl->hdl[i].hdl_value,

			hdl_tbl->hdl[i].type,

			hdl_tbl->hdl[i].state,

			hdl_tbl->hdl[i].dev_id);

}



int32_t cam_create_session_hdl(void *priv)

{

	int idx;
@@ -153,7 +139,6 @@ int32_t cam_create_session_hdl(void *priv) 
	idx = cam_get_free_handle_index();

	if (idx < 0) {

		CAM_ERR(CAM_CRM, "Unable to create session handle");

		cam_dump_tbl_info();

		spin_unlock_bh(&hdl_tbl_lock);

		return idx;

	}
@@ -189,7 +174,6 @@ int32_t cam_create_device_hdl(struct cam_create_dev_hdl *hdl_data) 
	if (idx < 0) {

		CAM_ERR(CAM_CRM,

			"Unable to create device handle(idx= %d)", idx);

		cam_dump_tbl_info();

		spin_unlock_bh(&hdl_tbl_lock);

		return idx;

	}