Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c93beaf authored by Yuval Mintz's avatar Yuval Mintz Committed by David S. Miller
Browse files

qed: Additional work toward cleaning C=1 



This cleans many of the warnings that would arise in qed as a
result of compilations with C=1; Most of those are the addition
of missing 'static' to functions, although there are several other
fixes as well.

Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@caviumnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0189efb8

drivers/net/ethernet/qlogic/qed/qed_cxt.c

+4 −4
Original line number Diff line number Diff line
@@ -344,14 +344,14 @@ static struct qed_tid_seg *qed_cxt_tid_seg_info(struct qed_hwfn *p_hwfn, 
	return NULL;

}



void qed_cxt_set_srq_count(struct qed_hwfn *p_hwfn, u32 num_srqs)

static void qed_cxt_set_srq_count(struct qed_hwfn *p_hwfn, u32 num_srqs)

{

	struct qed_cxt_mngr *p_mgr = p_hwfn->p_cxt_mngr;



	p_mgr->srq_count = num_srqs;

}



u32 qed_cxt_get_srq_count(struct qed_hwfn *p_hwfn)

static u32 qed_cxt_get_srq_count(struct qed_hwfn *p_hwfn)

{

	struct qed_cxt_mngr *p_mgr = p_hwfn->p_cxt_mngr;
@@ -1799,7 +1799,7 @@ int qed_cxt_get_cid_info(struct qed_hwfn *p_hwfn, struct qed_cxt_info *p_info) 
	return 0;

}



void qed_rdma_set_pf_params(struct qed_hwfn *p_hwfn,

static void qed_rdma_set_pf_params(struct qed_hwfn *p_hwfn,

				   struct qed_rdma_pf_params *p_params)

{

	u32 num_cons, num_tasks, num_qps, num_mrs, num_srqs;

drivers/net/ethernet/qlogic/qed/qed_debug.c

+28 −25
Original line number Diff line number Diff line
@@ -405,7 +405,7 @@ struct phy_defs { 
/***************************** Constant Arrays *******************************/



/* Debug arrays */

static struct dbg_array s_dbg_arrays[MAX_BIN_DBG_BUFFER_TYPE] = { {0} };

static struct dbg_array s_dbg_arrays[MAX_BIN_DBG_BUFFER_TYPE] = { {NULL} };



/* Chip constant definitions array */

static struct chip_defs s_chip_defs[MAX_CHIP_IDS] = {
@@ -4028,7 +4028,7 @@ static enum dbg_status qed_mcp_trace_read_meta(struct qed_hwfn *p_hwfn, 
}



/* Dump MCP Trace */

enum dbg_status qed_mcp_trace_dump(struct qed_hwfn *p_hwfn,

static enum dbg_status qed_mcp_trace_dump(struct qed_hwfn *p_hwfn,

					  struct qed_ptt *p_ptt,

					  u32 *dump_buf,

					  bool dump, u32 *num_dumped_dwords)
@@ -4130,7 +4130,7 @@ enum dbg_status qed_mcp_trace_dump(struct qed_hwfn *p_hwfn, 
}



/* Dump GRC FIFO */

enum dbg_status qed_reg_fifo_dump(struct qed_hwfn *p_hwfn,

static enum dbg_status qed_reg_fifo_dump(struct qed_hwfn *p_hwfn,

					 struct qed_ptt *p_ptt,

					 u32 *dump_buf,

					 bool dump, u32 *num_dumped_dwords)
@@ -4192,7 +4192,7 @@ enum dbg_status qed_reg_fifo_dump(struct qed_hwfn *p_hwfn, 
}



/* Dump IGU FIFO */

enum dbg_status qed_igu_fifo_dump(struct qed_hwfn *p_hwfn,

static enum dbg_status qed_igu_fifo_dump(struct qed_hwfn *p_hwfn,

					 struct qed_ptt *p_ptt,

					 u32 *dump_buf,

					 bool dump, u32 *num_dumped_dwords)
@@ -4255,10 +4255,11 @@ enum dbg_status qed_igu_fifo_dump(struct qed_hwfn *p_hwfn, 
}



/* Protection Override dump */

enum dbg_status qed_protection_override_dump(struct qed_hwfn *p_hwfn,

static enum dbg_status qed_protection_override_dump(struct qed_hwfn *p_hwfn,

						    struct qed_ptt *p_ptt,

						    u32 *dump_buf,

					     bool dump, u32 *num_dumped_dwords)

						    bool dump,

						    u32 *num_dumped_dwords)

{

	u32 offset = 0, size_param_offset, override_window_dwords;
@@ -6339,7 +6340,8 @@ enum dbg_status qed_print_fw_asserts_results(struct qed_hwfn *p_hwfn, 
}



/* Wrapper for unifying the idle_chk and mcp_trace api */

enum dbg_status qed_print_idle_chk_results_wrapper(struct qed_hwfn *p_hwfn,

static enum dbg_status

qed_print_idle_chk_results_wrapper(struct qed_hwfn *p_hwfn,

				   u32 *dump_buf,

				   u32 num_dumped_dwords,

				   char *results_buf)
@@ -6413,7 +6415,7 @@ static void qed_dbg_print_feature(u8 *p_text_buf, u32 text_size) 


#define QED_RESULTS_BUF_MIN_SIZE 16

/* Generic function for decoding debug feature info */

enum dbg_status format_feature(struct qed_hwfn *p_hwfn,

static enum dbg_status format_feature(struct qed_hwfn *p_hwfn,

				      enum qed_dbg_features feature_idx)

{

	struct qed_dbg_feature *feature =
@@ -6480,7 +6482,8 @@ enum dbg_status format_feature(struct qed_hwfn *p_hwfn, 
}



/* Generic function for performing the dump of a debug feature. */

enum dbg_status qed_dbg_dump(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,

static enum dbg_status qed_dbg_dump(struct qed_hwfn *p_hwfn,

				    struct qed_ptt *p_ptt,

				    enum qed_dbg_features feature_idx)

{

	struct qed_dbg_feature *feature =

drivers/net/ethernet/qlogic/qed/qed_dev.c

+3 −2
Original line number Diff line number Diff line
@@ -497,12 +497,13 @@ int qed_resc_alloc(struct qed_dev *cdev) 
		if (p_hwfn->hw_info.personality == QED_PCI_ETH_ROCE) {

			num_cons = qed_cxt_get_proto_cid_count(p_hwfn,

							       PROTOCOLID_ROCE,

							       0) * 2;

							       NULL) * 2;

			n_eqes += num_cons + 2 * MAX_NUM_VFS_BB;

		} else if (p_hwfn->hw_info.personality == QED_PCI_ISCSI) {

			num_cons =

			    qed_cxt_get_proto_cid_count(p_hwfn,

							PROTOCOLID_ISCSI, 0);

							PROTOCOLID_ISCSI,

							NULL);

			n_eqes += 2 * num_cons;

		}

drivers/net/ethernet/qlogic/qed/qed_ll2.c

+6 −9
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ static void qed_ll2_kill_buffers(struct qed_dev *cdev) 
		qed_ll2_dealloc_buffer(cdev, buffer);

}



void qed_ll2b_complete_rx_packet(struct qed_hwfn *p_hwfn,

static void qed_ll2b_complete_rx_packet(struct qed_hwfn *p_hwfn,

					u8 connection_handle,

					struct qed_ll2_rx_packet *p_pkt,

					struct core_rx_fast_path_cqe *p_cqe,
@@ -516,7 +516,7 @@ static int qed_ll2_rxq_completion(struct qed_hwfn *p_hwfn, void *cookie) 
	return rc;

}



void qed_ll2_rxq_flush(struct qed_hwfn *p_hwfn, u8 connection_handle)

static void qed_ll2_rxq_flush(struct qed_hwfn *p_hwfn, u8 connection_handle)

{

	struct qed_ll2_info *p_ll2_conn = NULL;

	struct qed_ll2_rx_packet *p_pkt = NULL;
@@ -1124,9 +1124,6 @@ static void qed_ll2_prepare_tx_packet_set_bd(struct qed_hwfn *p_hwfn, 
	DMA_REGPAIR_LE(start_bd->addr, first_frag);

	start_bd->nbytes = cpu_to_le16(first_frag_len);



	SET_FIELD(start_bd->bd_flags.as_bitfield, CORE_TX_BD_FLAGS_ROCE_FLAV,

		  type);



	DP_VERBOSE(p_hwfn,

		   (NETIF_MSG_TX_QUEUED | QED_MSG_LL2),

		   "LL2 [q 0x%02x cid 0x%08x type 0x%08x] Tx Producer at [0x%04x] - set with a %04x bytes %02x BDs buffer at %08x:%08x\n",

drivers/net/ethernet/qlogic/qed/qed_main.c

+1 −1
Original line number Diff line number Diff line
@@ -1430,7 +1430,7 @@ static int qed_set_led(struct qed_dev *cdev, enum qed_led_mode mode) 
	return status;

}



struct qed_selftest_ops qed_selftest_ops_pass = {

static struct qed_selftest_ops qed_selftest_ops_pass = {

	.selftest_memory = &qed_selftest_memory,

	.selftest_interrupt = &qed_selftest_interrupt,

	.selftest_register = &qed_selftest_register,