Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b612434 authored by Neil Horman's avatar Neil Horman Committed by Robert Love
Browse files

fcoe: make sure fcoe frames are unshared prior to manipulating them 



Based on my last patch I noticed that fcoe_rcv has a simmilar problem, in that
it manipulates the passed in skb without checking to see if it has other users.
Making manipulations to a shared skb can result in various corruptions.

Easy fix, just make sure the skb is unshared prior to doing anything with it.

Signed-off-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
parent c0866286

drivers/scsi/fcoe/fcoe.c

+6 −0
Original line number Diff line number Diff line
@@ -1452,6 +1452,12 @@ static int fcoe_rcv(struct sk_buff *skb, struct net_device *netdev, 
			skb_tail_pointer(skb), skb_end_pointer(skb),

			skb->csum, skb->dev ? skb->dev->name : "<NULL>");





	skb = skb_share_check(skb, GFP_ATOMIC);



	if (skb == NULL)

		return NET_RX_DROP;



	eh = eth_hdr(skb);



	if (is_fip_mode(ctlr) &&