Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89036f23 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller
Browse files

net: hisilicon: hns: Replace mdelay() with msleep() 



hns_ppe_common_init_hw() and hns_xgmac_init() are never
called in atomic context.
They call mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2bcd619e

drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c

+2 −2
Original line number Diff line number Diff line
@@ -204,9 +204,9 @@ static int hns_ppe_common_init_hw(struct ppe_common_cb *ppe_common) 
	enum dsaf_mode dsaf_mode = dsaf_dev->dsaf_mode;



	dsaf_dev->misc_op->ppe_comm_srst(dsaf_dev, 0);

	mdelay(100);

	msleep(100);

	dsaf_dev->misc_op->ppe_comm_srst(dsaf_dev, 1);

	mdelay(100);

	msleep(100);



	if (ppe_common->ppe_mode == PPE_COMMON_MODE_SERVICE) {

		switch (dsaf_mode) {

drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c

+2 −2
Original line number Diff line number Diff line
@@ -215,10 +215,10 @@ static void hns_xgmac_init(void *mac_drv) 
	u32 port = drv->mac_id;



	dsaf_dev->misc_op->xge_srst(dsaf_dev, port, 0);

	mdelay(100);

	msleep(100);

	dsaf_dev->misc_op->xge_srst(dsaf_dev, port, 1);



	mdelay(100);

	msleep(100);

	hns_xgmac_lf_rf_control_init(drv);

	hns_xgmac_exc_irq_en(drv, 0);