Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2bcd619e authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller
Browse files

net: amd: pcnet32: Replace GFP_ATOMIC with GFP_KERNEL in pcnet32_alloc_ring() 



pcnet32_alloc_ring() is never called in atomic context.
It calls kcalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2db6dc26

drivers/net/ethernet/amd/pcnet32.c

+4 −4
Original line number Diff line number Diff line
@@ -2036,22 +2036,22 @@ static int pcnet32_alloc_ring(struct net_device *dev, const char *name) 
	}



	lp->tx_dma_addr = kcalloc(lp->tx_ring_size, sizeof(dma_addr_t),

				  GFP_ATOMIC);

				  GFP_KERNEL);

	if (!lp->tx_dma_addr)

		return -ENOMEM;



	lp->rx_dma_addr = kcalloc(lp->rx_ring_size, sizeof(dma_addr_t),

				  GFP_ATOMIC);

				  GFP_KERNEL);

	if (!lp->rx_dma_addr)

		return -ENOMEM;



	lp->tx_skbuff = kcalloc(lp->tx_ring_size, sizeof(struct sk_buff *),

				GFP_ATOMIC);

				GFP_KERNEL);

	if (!lp->tx_skbuff)

		return -ENOMEM;



	lp->rx_skbuff = kcalloc(lp->rx_ring_size, sizeof(struct sk_buff *),

				GFP_ATOMIC);

				GFP_KERNEL);

	if (!lp->rx_skbuff)

		return -ENOMEM;