Commit 79f08904 authored Nov 21, 2019 by Navid Emamdoost Committed by Greg Kroah-Hartman Dec 13, 2019

Input: Fix memory leak in psxpad_spi_probe



In the implementation of psxpad_spi_probe() the allocated memory for
pdev is leaked if psxpad_spi_init_ff() or input_register_polled_device()
fail. The solution is using device managed allocation, like the one used
for pad. Perform the allocation using
devm_input_allocate_polled_device().

Fixes: 8be193c7 ("Input: add support for PlayStation 1/2 joypads connected via SPI")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7c193ed6

drivers/input/joystick/psxpad-spi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -292,7 +292,7 @@ static int psxpad_spi_probe(struct spi_device *spi)
		if (!pad)
		return -ENOMEM;

		pdev = input_allocate_polled_device();
		pdev = devm_input_allocate_polled_device(&spi->dev);
		if (!pdev) {
		dev_err(&spi->dev, "failed to allocate input device\n");
		return -ENOMEM;