Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 785185f4 authored by kbuild test robot's avatar kbuild test robot Committed by Greg Kroah-Hartman
Browse files

staging: ccree: fix ifnullfree.cocci warnings 



drivers/staging/ccree/ssi_hash.c:317:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:320:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:323:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:373:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:375:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:377:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:379:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:381:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/ccree/ssi_hash.c:383:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: default avatarGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eba44af3

drivers/staging/ccree/ssi_hash.c

+9 −18
Original line number Diff line number Diff line
@@ -314,13 +314,10 @@ static int ssi_hash_map_request(struct device *dev, 
		state->digest_buff_dma_addr = 0;

	}

fail3:

	if (state->opad_digest_buff != NULL)

	kfree(state->opad_digest_buff);

fail2:

	if (state->digest_bytes_len != NULL)

	kfree(state->digest_bytes_len);

fail1:

	if (state->digest_buff != NULL)

	 kfree(state->digest_buff);

fail_digest_result_buff:

	 if (state->digest_result_buff != NULL) {
@@ -370,17 +367,11 @@ static void ssi_hash_unmap_request(struct device *dev, 
		state->opad_digest_dma_addr = 0;

	}



	if (state->opad_digest_buff != NULL)

	kfree(state->opad_digest_buff);

	if (state->digest_bytes_len != NULL)

	kfree(state->digest_bytes_len);

	if (state->digest_buff != NULL)

	kfree(state->digest_buff);

	if (state->digest_result_buff != NULL) 

	kfree(state->digest_result_buff);

	if (state->buff1 != NULL) 

	kfree(state->buff1);

	if (state->buff0 != NULL)

	kfree(state->buff0);

}