Commit eba44af3 authored Apr 23, 2017 by kbuild test robot Committed by Greg Kroah-Hartman Apr 28, 2017

staging: ccree: fix ifnullfree.cocci warnings

drivers/staging/ccree/ssi_buffer_mgr.c:530:3-19: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

NULL check before some freeing functions is not needed.

Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9cbd7dca

drivers/staging/ccree/ssi_buffer_mgr.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1863,7 +1863,6 @@ int ssi_buffer_mgr_fini(struct ssi_drvdata *drvdata)
		struct buff_mgr_handle *buff_mgr_handle = drvdata->buff_mgr_handle;

		if (buff_mgr_handle != NULL) {
		if (buff_mgr_handle->mlli_buffs_pool != NULL)
		dma_pool_destroy(buff_mgr_handle->mlli_buffs_pool);
		kfree(drvdata->buff_mgr_handle);
		drvdata->buff_mgr_handle = NULL;