Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7604df6e authored by Reinette Chatre's avatar Reinette Chatre Committed by Thomas Gleixner
Browse files

x86/intel_rdt: Support flexible data to parsing callbacks 



Each resource is associated with a configurable callback that should be
used to parse the information provided for the particular resource from
user space. In addition to the resource and domain pointers this callback
is provided with just the character buffer being parsed.

In support of flexible parsing the callback is modified to support a void
pointer as argument. This enables resources that need more data than just
the user provided data to pass its required data to the callback without
affecting the signatures for the callbacks of all the other resources.

Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: fenghua.yu@intel.com
Cc: tony.luck@intel.com
Cc: vikas.shivappa@linux.intel.com
Cc: gavin.hindman@intel.com
Cc: jithu.joseph@intel.com
Cc: dave.hansen@intel.com
Cc: hpa@zytor.com
Link: https://lkml.kernel.org/r/34baacfced4d787d994ec7015e249e6c7e619053.1529706536.git.reinette.chatre@intel.com
parent 9af4c0a6

arch/x86/kernel/cpu/intel_rdt.h

+3 −3
Original line number Diff line number Diff line
@@ -371,7 +371,7 @@ struct rdt_resource { 
	struct rdt_cache	cache;

	struct rdt_membw	membw;

	const char		*format_str;

	int (*parse_ctrlval)	(char *buf, struct rdt_resource *r,

	int (*parse_ctrlval)	(void *data, struct rdt_resource *r,

				 struct rdt_domain *d);

	struct list_head	evt_list;

	int			num_rmid;
@@ -379,8 +379,8 @@ struct rdt_resource { 
	unsigned long		fflags;

};



int parse_cbm(char *buf, struct rdt_resource *r, struct rdt_domain *d);

int parse_bw(char *buf, struct rdt_resource *r,  struct rdt_domain *d);

int parse_cbm(void *_data, struct rdt_resource *r, struct rdt_domain *d);

int parse_bw(void *_buf, struct rdt_resource *r,  struct rdt_domain *d);



extern struct mutex rdtgroup_mutex;

arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c

+4 −2
Original line number Diff line number Diff line
@@ -64,9 +64,10 @@ static bool bw_validate(char *buf, unsigned long *data, struct rdt_resource *r) 
	return true;

}



int parse_bw(char *buf, struct rdt_resource *r, struct rdt_domain *d)

int parse_bw(void *_buf, struct rdt_resource *r, struct rdt_domain *d)

{

	unsigned long data;

	char *buf = _buf;



	if (d->have_new_ctrl) {

		rdt_last_cmd_printf("duplicate domain %d\n", d->id);
@@ -126,8 +127,9 @@ static bool cbm_validate(char *buf, u32 *data, struct rdt_resource *r) 
 * Read one cache bit mask (hex). Check that it is valid for the current

 * resource type.

 */

int parse_cbm(char *buf, struct rdt_resource *r, struct rdt_domain *d)

int parse_cbm(void *_data, struct rdt_resource *r, struct rdt_domain *d)

{

	char *buf = _data;

	u32 cbm_val;



	if (d->have_new_ctrl) {