Commit 9af4c0a6 authored Jun 22, 2018 by Reinette Chatre Committed by Thomas Gleixner Jun 23, 2018

x86/intel_rdt: Making CBM name and type more explicit



cbm_validate() receives a pointer to the variable that will be initialized
with a validated capacity bitmask. The pointer points to a variable of type
unsigned long that is immediately assigned to a variable of type u32 by the
caller on return from cbm_validate().

Let cbm_validate() initialize a variable of type u32 directly.

At this time also change tha variable name "data" within parse_cbm() to a
name more reflective of the content: "cbm_val". This frees up the generic
"data" to be used later when it is indeed used for a collection of input.

Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: fenghua.yu@intel.com
Cc: tony.luck@intel.com
Cc: vikas.shivappa@linux.intel.com
Cc: gavin.hindman@intel.com
Cc: jithu.joseph@intel.com
Cc: dave.hansen@intel.com
Cc: hpa@zytor.com
Link: https://lkml.kernel.org/r/5e29cf0209ea2deac9beacd35cbe5239a50959fb.1529706536.git.reinette.chatre@intel.com

parent 49f7b4ef

arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -87,7 +87,7 @@ int parse_bw(char buf, struct rdt_resource r, struct rdt_domain *d)
		* are allowed (e.g. FFFFH, 0FF0H, 003CH, etc.).
		* Additionally Haswell requires at least two bits set.
		*/
		static bool cbm_validate(char buf, unsigned long data, struct rdt_resource *r)
		static bool cbm_validate(char buf, u32 data, struct rdt_resource *r)
		{
		unsigned long first_bit, zero_bit, val;
		unsigned int cbm_len = r->cache.cbm_len;
		@@ -128,16 +128,17 @@ static bool cbm_validate(char buf, unsigned long data, struct rdt_resource *r)
		*/
		int parse_cbm(char buf, struct rdt_resource r, struct rdt_domain *d)
		{
		unsigned long data;
		u32 cbm_val;

		if (d->have_new_ctrl) {
		rdt_last_cmd_printf("duplicate domain %d\n", d->id);
		return -EINVAL;
		}

		if(!cbm_validate(buf, &data, r))
		if (!cbm_validate(buf, &cbm_val, r))
		return -EINVAL;
		d->new_ctrl = data;

		d->new_ctrl = cbm_val;
		d->have_new_ctrl = true;

		return 0;