Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ae5e060 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

em28xx: Make all em28xx extensions to be initialized asynchronously 



em28xx-dvb, em28xx-alsa and em28xx-ir are typically initialized
asyncrhronously. The exception for it is when those modules
are loaded before em28xx (or before an em28xx card insertion) or
when they're built in.

Make the extentions to always load asynchronously. That allows
having all DVB firmwares loaded synchronously with udev-182.

Antti tested it with the following hardware:
	Hauppauge WinTV HVR 930C
	MaxMedia UB425-TC
	PCTV QuatroStick nano (520e)

Tested-by: default avatarAntti Palosaari <crope@iki.fi>
Cc: stable@kernel.org # for Kernel 3.6 - please note that driver location has changed
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 351d1878

drivers/media/usb/em28xx/em28xx-cards.c

+10 −12
Original line number Diff line number Diff line
@@ -2875,12 +2875,20 @@ static void em28xx_card_setup(struct em28xx *dev) 
}





#if defined(CONFIG_MODULES) && defined(MODULE)

static void request_module_async(struct work_struct *work)

{

	struct em28xx *dev = container_of(work,

			     struct em28xx, request_module_wk);



	/*

	 * The em28xx extensions can be modules or builtin. If the

	 * modules are already loaded or are built in, those extensions

	 * can be initialised right now. Otherwise, the module init

	 * code will do it.

	 */

	em28xx_init_extension(dev);



#if defined(CONFIG_MODULES) && defined(MODULE)

	if (dev->has_audio_class)

		request_module("snd-usb-audio");

	else if (dev->has_alsa_audio)
@@ -2890,6 +2898,7 @@ static void request_module_async(struct work_struct *work) 
		request_module("em28xx-dvb");

	if (dev->board.ir_codes && !disable_ir)

		request_module("em28xx-rc");

#endif /* CONFIG_MODULES */

}



static void request_modules(struct em28xx *dev)
@@ -2902,10 +2911,6 @@ static void flush_request_modules(struct em28xx *dev) 
{

	flush_work_sync(&dev->request_module_wk);

}

#else

#define request_modules(dev)

#define flush_request_modules(dev)

#endif /* CONFIG_MODULES */



/*

 * em28xx_release_resources()
@@ -3324,13 +3329,6 @@ static int em28xx_usb_probe(struct usb_interface *interface, 
	 */

	mutex_unlock(&dev->lock);



	/*

	 * These extensions can be modules. If the modules are already

	 * loaded then we can initialise the device now, otherwise we

	 * will initialise it when the modules load instead.

	 */

	em28xx_init_extension(dev);



	return 0;



unlock_and_free: