Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 351d1878 authored by Michael Krufky's avatar Michael Krufky Committed by Mauro Carvalho Chehab
Browse files

[media] tda18271: properly report read errors in tda18271_get_id 



Until now, if there is a read error in tda18271_get_id, the driver
reports "Unknown device..."  Instead, check the return value of
tda18271_read_regs and display the appropriate error message.

Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 6b82e0cf

drivers/media/tuners/tda18271-fe.c

+9 −1
Original line number Diff line number Diff line
@@ -1159,11 +1159,19 @@ static int tda18271_get_id(struct dvb_frontend *fe) 
	struct tda18271_priv *priv = fe->tuner_priv;

	unsigned char *regs = priv->tda18271_regs;

	char *name;

	int ret;



	mutex_lock(&priv->lock);

	tda18271_read_regs(fe);

	ret = tda18271_read_regs(fe);

	mutex_unlock(&priv->lock);



	if (ret) {

		tda_info("Error reading device ID @ %d-%04x, bailing out.\n",

			 i2c_adapter_id(priv->i2c_props.adap),

			 priv->i2c_props.addr);

		return -EIO;

	}



	switch (regs[R_ID] & 0x7f) {

	case 3:

		name = "TDA18271HD/C1";