Commit 6757a430 authored Aug 30, 2020 by Tom Rix Committed by Greg Kroah-Hartman Oct 29, 2020

media: tc358743: initialize variable



[ Upstream commit 274cf92d5dff5c2fec1a518078542ffe70d07646 ]

clang static analysis flags this error

tc358743.c:1468:9: warning: Branch condition evaluates
  to a garbage value
        return handled ? IRQ_HANDLED : IRQ_NONE;
               ^~~~~~~
handled should be initialized to false.

Fixes: d747b806 ("[media] tc358743: add direct interrupt handling")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4cf628ac

drivers/media/i2c/tc358743.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1461,7 +1461,7 @@ static int tc358743_isr(struct v4l2_subdev sd, u32 status, bool handled)
		static irqreturn_t tc358743_irq_handler(int irq, void *dev_id)
		{
		struct tc358743_state *state = dev_id;
		bool handled;
		bool handled = false;

		tc358743_isr(&state->sd, 0, &handled);