Commit 4cf628ac authored Aug 26, 2020 by Dinghao Liu Committed by Greg Kroah-Hartman Oct 29, 2020

media: mx2_emmaprp: Fix memleak in emmaprp_probe



[ Upstream commit 21d387b8d372f859d9e87fdcc7c3b4a432737f4d ]

When platform_get_irq() fails, we should release
vfd and unregister pcdev->v4l2_dev just like the
subsequent error paths.

Fixes: d4e192cc ("media: mx2_emmaprp: Check for platform_get_irq() error")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 97b40006

drivers/media/platform/mx2_emmaprp.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -929,8 +929,11 @@ static int emmaprp_probe(struct platform_device *pdev)
		platform_set_drvdata(pdev, pcdev);

		irq = platform_get_irq(pdev, 0);
		if (irq < 0)
		return irq;
		if (irq < 0) {
		ret = irq;
		goto rel_vdev;
		}

		ret = devm_request_irq(&pdev->dev, irq, emmaprp_irq, 0,
		dev_name(&pdev->dev), pcdev);
		if (ret)