Commit 62c60697 authored Nov 20, 2014 by Julia Lawall Committed by Felipe Balbi Nov 20, 2014

usb: dwc3: keystone: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent a4722fd3

drivers/usb/dwc3/dwc3-keystone.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -123,6 +123,7 @@ static int kdwc3_probe(struct platform_device *pdev)
		irq = platform_get_irq(pdev, 0);
		if (irq < 0) {
		dev_err(&pdev->dev, "missing irq\n");
		error = irq;
		goto err_irq;
		}