Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4722fd3 authored by Felipe Balbi's avatar Felipe Balbi
Browse files

usb: dwc3: trace: don't save pointers 



There was another instance where we were
holding pointers which could be long gone.

Fix that by caching only values pointed to
by such pointer.

Because no crash has been observed, this patch
will be sent on v3.19 merge window, instead of
-rc.

Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent f905bc68

drivers/usb/dwc3/trace.h

+8 −4
Original line number Diff line number Diff line
@@ -175,17 +175,21 @@ DECLARE_EVENT_CLASS(dwc3_log_gadget_ep_cmd, 
	TP_STRUCT__entry(

		__dynamic_array(char, name, DWC3_MSG_MAX)

		__field(unsigned int, cmd)

		__field(struct dwc3_gadget_ep_cmd_params *, params)

		__field(u32, param0)

		__field(u32, param1)

		__field(u32, param2)

	),

	TP_fast_assign(

		snprintf(__get_str(name), DWC3_MSG_MAX, "%s", dep->name);

		__entry->cmd = cmd;

		__entry->params = params;

		__entry->param0 = params->param0;

		__entry->param1 = params->param1;

		__entry->param2 = params->param2;

	),

	TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x",

		__get_str(name), dwc3_gadget_ep_cmd_string(__entry->cmd),

		__entry->cmd, __entry->params->param0,

		__entry->params->param1, __entry->params->param2

		__entry->cmd, __entry->param0,

		__entry->param1, __entry->param2

	)

);