Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5fb005c4 authored by Dave Airlie's avatar Dave Airlie Committed by Alex Deucher
Browse files

amdgpu/dc: make dce transform constructor void 



This never returns anything but true.

Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 9cf29399

drivers/gpu/drm/amd/display/dc/dce/dce_transform.c

+1 −3
Original line number Diff line number Diff line
@@ -1437,7 +1437,7 @@ static const struct transform_funcs dce_transform_funcs = { 
/* Constructor, Destructor               */

/*****************************************/



bool dce_transform_construct(

void dce_transform_construct(

	struct dce_transform *xfm_dce,

	struct dc_context *ctx,

	uint32_t inst,
@@ -1462,6 +1462,4 @@ bool dce_transform_construct( 


	xfm_dce->lb_bits_per_entry = LB_BITS_PER_ENTRY;

	xfm_dce->lb_memory_size = LB_TOTAL_NUMBER_OF_ENTRIES; /*0x6B0*/



	return true;

}

drivers/gpu/drm/amd/display/dc/dce/dce_transform.h

+1 −1
Original line number Diff line number Diff line
@@ -481,7 +481,7 @@ struct dce_transform { 
	bool prescaler_on;

};



bool dce_transform_construct(struct dce_transform *xfm_dce,

void dce_transform_construct(struct dce_transform *xfm_dce,

	struct dc_context *ctx,

	uint32_t inst,

	const struct dce_transform_registers *regs,

drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c

+3 −8
Original line number Diff line number Diff line
@@ -486,16 +486,11 @@ static struct transform *dce100_transform_create( 
	if (!transform)

		return NULL;



	if (dce_transform_construct(transform, ctx, inst,

			&xfm_regs[inst], &xfm_shift, &xfm_mask)) {

	dce_transform_construct(transform, ctx, inst,

				&xfm_regs[inst], &xfm_shift, &xfm_mask);

	return &transform->base;

}



	BREAK_TO_DEBUGGER();

	kfree(transform);

	return NULL;

}



static struct input_pixel_processor *dce100_ipp_create(

	struct dc_context *ctx, uint32_t inst)

{

drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c

+3 −7
Original line number Diff line number Diff line
@@ -526,13 +526,9 @@ static struct transform *dce110_transform_create( 
	if (!transform)

		return NULL;



	if (dce_transform_construct(transform, ctx, inst,

			&xfm_regs[inst], &xfm_shift, &xfm_mask))

	dce_transform_construct(transform, ctx, inst,

				&xfm_regs[inst], &xfm_shift, &xfm_mask);

	return &transform->base;



	BREAK_TO_DEBUGGER();

	kfree(transform);

	return NULL;

}



static struct input_pixel_processor *dce110_ipp_create(

drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c

+4 −9
Original line number Diff line number Diff line
@@ -521,17 +521,12 @@ static struct transform *dce112_transform_create( 
	if (!transform)

		return NULL;



	if (dce_transform_construct(transform, ctx, inst,

			&xfm_regs[inst], &xfm_shift, &xfm_mask)) {

	dce_transform_construct(transform, ctx, inst,

				&xfm_regs[inst], &xfm_shift, &xfm_mask);

	transform->lb_memory_size = 0x1404; /*5124*/

	return &transform->base;

}



	BREAK_TO_DEBUGGER();

	kfree(transform);

	return NULL;

}



static const struct encoder_feature_support link_enc_feature = {

		.max_hdmi_deep_color = COLOR_DEPTH_121212,

		.max_hdmi_pixel_clock = 600000,