net: fec: Fix sparse warnings with different lock contexts for basic block
reproduce:
make ARCH=arm C=1 2>fec.txt drivers/net/ethernet/freescale/fec_main.o
cat fec.txt
sparse warnings:
drivers/net/ethernet/freescale/fec_main.c:2916:12: warning: context imbalance
in 'fec_set_features' - different lock contexts for basic block
Christopher Li suggest to change as below:
if (need_lock) {
lock();
do_something_real();
unlock();
} else {
do_something_real();
}
Reported-by:
Fabio Estevam <festevam@gmail.com>
Suggested-by:
Christopher Li <sparse@chrisli.org>
Signed-off-by:
Fugang Duan <B38611@freescale.com>
Signed-off-by:
David S. Miller <davem@davemloft.net>
Loading
Please register or sign in to comment