Commit 5acb07ea authored Nov 25, 2014 by Markus Elfring Committed by Rob Clark Dec 17, 2014

drm/msm: Deletion of unnecessary checks before the function call "release_firmware"



The release_firmware() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>

parent 264f7d67

drivers/gpu/drm/msm/adreno/adreno_gpu.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -386,9 +386,7 @@ void adreno_gpu_cleanup(struct adreno_gpu *gpu)
		msm_gem_put_iova(gpu->memptrs_bo, gpu->base.id);
		drm_gem_object_unreference(gpu->memptrs_bo);
		}
		if (gpu->pm4)
		release_firmware(gpu->pm4);
		if (gpu->pfp)
		release_firmware(gpu->pfp);
		msm_gpu_cleanup(&gpu->base);
		}