Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 264f7d67 authored Nov 25, 2014 by Markus Elfring Committed by Rob Clark Dec 17, 2014

drm/msm: Deletion of unnecessary checks before two function calls



The functions framebuffer_release() and vunmap() perform also input
parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>

parent 4e0cd681

drivers/gpu/drm/msm/msm_fbdev.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -190,7 +190,6 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
	fail:		fail:

	if (ret) {		if (ret) {
	if (fbi)
	framebuffer_release(fbi);		framebuffer_release(fbi);
	if (fb) {		if (fb) {
	drm_framebuffer_unregister_private(fb);		drm_framebuffer_unregister_private(fb);

drivers/gpu/drm/msm/msm_gem.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -535,7 +535,6 @@ void msm_gem_free_object(struct drm_gem_object *obj)
	drm_free_large(msm_obj->pages);		drm_free_large(msm_obj->pages);

	} else {		} else {
	if (msm_obj->vaddr)
	vunmap(msm_obj->vaddr);		vunmap(msm_obj->vaddr);
	put_pages(obj);		put_pages(obj);
	}		}