Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 58874c7b authored by Sudarsana Reddy Kalluru's avatar Sudarsana Reddy Kalluru Committed by David S. Miller
Browse files

qed: Fix possible race for the link state value. 



There's a possible race where driver can read link status in mid-transition
and see that virtual-link is up yet speed is 0. Since in this
mid-transition we're guaranteed to see a mailbox from MFW soon, we can
afford to treat this as link down.

Fixes: cc875c2e ("qed: Add link support")
Signed-off-by: default avatarSudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
Signed-off-by: default avatarAriel Elior <ariel.elior@cavium.com>
Signed-off-by: default avatarMichal Kalderon <Michal.Kalderon@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4ad95a93

drivers/net/ethernet/qlogic/qed/qed_mcp.c

+1 −0
Original line number Diff line number Diff line
@@ -1211,6 +1211,7 @@ static void qed_mcp_handle_link_change(struct qed_hwfn *p_hwfn, 
		break;

	default:

		p_link->speed = 0;

		p_link->link_up = 0;

	}



	if (p_link->link_up && p_link->speed)