Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ad95a93 authored by Sudarsana Reddy Kalluru's avatar Sudarsana Reddy Kalluru Committed by David S. Miller
Browse files

qed: Fix link flap issue due to mismatching EEE capabilities. 



Apparently, MFW publishes EEE capabilities even for Fiber-boards that don't
support them, and later since qed internally sets adv_caps it would cause
link-flap avoidance (LFA) to fail when driver would initiate the link.
This in turn delays the link, causing traffic to fail.

Driver has been modified to not to ask MFW for any EEE config if EEE isn't
to be enabled.

Fixes: 645874e5 ("qed: Add support for Energy efficient ethernet.")
Signed-off-by: default avatarSudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
Signed-off-by: default avatarAriel Elior <ariel.elior@cavium.com>
Signed-off-by: default avatarMichal Kalderon <Michal.Kalderon@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 64119e05

drivers/net/ethernet/qlogic/qed/qed_mcp.c

+9 −3
Original line number Diff line number Diff line
@@ -1308,8 +1308,14 @@ int qed_mcp_set_link(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt, bool b_up) 
	phy_cfg.pause |= (params->pause.forced_tx) ? ETH_PAUSE_TX : 0;

	phy_cfg.adv_speed = params->speed.advertised_speeds;

	phy_cfg.loopback_mode = params->loopback_mode;

	if (p_hwfn->mcp_info->capabilities & FW_MB_PARAM_FEATURE_SUPPORT_EEE) {

		if (params->eee.enable)



	/* There are MFWs that share this capability regardless of whether

	 * this is feasible or not. And given that at the very least adv_caps

	 * would be set internally by qed, we want to make sure LFA would

	 * still work.

	 */

	if ((p_hwfn->mcp_info->capabilities &

	     FW_MB_PARAM_FEATURE_SUPPORT_EEE) && params->eee.enable) {

		phy_cfg.eee_cfg |= EEE_CFG_EEE_ENABLED;

		if (params->eee.tx_lpi_enable)

			phy_cfg.eee_cfg |= EEE_CFG_TX_LPI;