Commit 57939021 authored Apr 04, 2018 by Jason Gunthorpe

RDMA/qedr: Zero stack memory before copying to user space



The fact this struct was not init'd like all the others was missed when
the padding reserved field was added.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 71e80a47 ("RDMA/qedr: Fix uABI structure layouts for 32/64 compat")
Acked-by: Michal Kalderon <Michal.Kalderon@cavium.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 2d93fc85

drivers/infiniband/hw/qedr/verbs.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -473,9 +473,9 @@ struct ib_pd qedr_alloc_pd(struct ib_device ibdev,
		pd->pd_id = pd_id;

		if (udata && context) {
		struct qedr_alloc_pd_uresp uresp;

		uresp.pd_id = pd_id;
		struct qedr_alloc_pd_uresp uresp = {
		.pd_id = pd_id,
		};

		rc = qedr_ib_copy_to_udata(udata, &uresp, sizeof(uresp));
		if (rc) {