Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4192c77f authored by Hans Verkuil's avatar Hans Verkuil Committed by Greg Kroah-Hartman
Browse files

media: vimc: zero the media_device on probe 



[ Upstream commit f74267b51cb36321f777807b2e04ca02167ecc08 ]

The media_device is part of a static global vimc_device struct.
The media framework expects this to be zeroed before it is
used, however, since this is a global this is not the case if
vimc is unbound and then bound again.

So call memset to ensure any left-over values are cleared.

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent fd1ade15

drivers/media/platform/vimc/vimc-core.c

+2 −0
Original line number Diff line number Diff line
@@ -303,6 +303,8 @@ static int vimc_probe(struct platform_device *pdev) 


	dev_dbg(&pdev->dev, "probe");



	memset(&vimc->mdev, 0, sizeof(vimc->mdev));



	/* Create platform_device for each entity in the topology*/

	vimc->subdevs = devm_kcalloc(&vimc->pdev.dev, vimc->pipe_cfg->num_ents,

				     sizeof(*vimc->subdevs), GFP_KERNEL);