Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40de37d2 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

3c589_cs: Fix an error handling path in tc589_probe() 



commit 640bf95b2c7c2981fb471acdafbd3e0458f8390d upstream.

Should tc589_config() fail, some resources need to be released as already
done in the remove function.

Fixes: 15b99ac1 ("[PATCH] pcmcia: add return value to _config() functions")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/d8593ae867b24c79063646e36f9b18b0790107cb.1684575975.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 79d5df82

drivers/net/ethernet/3com/3c589_cs.c

+10 −1
Original line number Diff line number Diff line
@@ -196,6 +196,7 @@ static int tc589_probe(struct pcmcia_device *link) 
{

	struct el3_private *lp;

	struct net_device *dev;

	int ret;



	dev_dbg(&link->dev, "3c589_attach()\n");
@@ -219,7 +220,15 @@ static int tc589_probe(struct pcmcia_device *link) 


	dev->ethtool_ops = &netdev_ethtool_ops;



	return tc589_config(link);

	ret = tc589_config(link);

	if (ret)

		goto err_free_netdev;



	return 0;



err_free_netdev:

	free_netdev(dev);

	return ret;

}



static void tc589_detach(struct pcmcia_device *link)