Commit 79d5df82 authored May 20, 2023 by Christophe JAILLET Committed by Greg Kroah-Hartman May 30, 2023

forcedeth: Fix an error handling path in nv_probe()



commit 5b17a4971d3b2a073f4078dd65331efbe35baa2d upstream.

If an error occures after calling nv_mgmt_acquire_sema(), it should be
undone with a corresponding nv_mgmt_release_sema() call.

Add it in the error handling path of the probe as already done in the
remove function.

Fixes: cac1c52c ("forcedeth: mgmt unit interface")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>
Link: https://lore.kernel.org/r/355e9a7d351b32ad897251b6f81b5886fcdc6766.1684571393.git.christophe.jaillet@wanadoo.fr


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f2ef3658

drivers/net/ethernet/nvidia/forcedeth.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -6061,6 +6061,7 @@ static int nv_probe(struct pci_dev pci_dev, const struct pci_device_id id)
		return 0;

		out_error:
		nv_mgmt_release_sema(dev);
		if (phystate_orig)
		writel(phystate\|NVREG_ADAPTCTL_RUNNING, base + NvRegAdapterControl);
		out_freering: