Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e1d9c6f authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by Sebastian Reichel
Browse files

power: olpc_battery: clean up eeprom read function 



The change removes redundant sysfs binary file boundary check while
reading eeprom content from userspace, the check is done on caller
side in fs/sysfs/file.c, if binary attribute size is not zero.

Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent 9f28b865

drivers/power/olpc_battery.c

+1 −6
Original line number Diff line number Diff line
@@ -521,11 +521,6 @@ static ssize_t olpc_bat_eeprom_read(struct file *filp, struct kobject *kobj, 
	int ret;

	int i;



	if (off >= EEPROM_SIZE)

		return 0;

	if (off + count > EEPROM_SIZE)

		count = EEPROM_SIZE - off;



	for (i = 0; i < count; i++) {

		ec_byte = EEPROM_START + off + i;

		ret = olpc_ec_cmd(EC_BAT_EEPROM, &ec_byte, 1, &buf[i], 1);
@@ -545,7 +540,7 @@ static struct bin_attribute olpc_bat_eeprom = { 
		.name = "eeprom",

		.mode = S_IRUGO,

	},

	.size = 0,

	.size = EEPROM_SIZE,

	.read = olpc_bat_eeprom_read,

};