Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f28b865 authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by Sebastian Reichel
Browse files

power: ds2781_battery: clean up eeprom read/write functions 



The change removes redundant calculation of left space on eeprom while
reading or writing "param_eeprom" or "user_eeprom", the checks are not
needed, since this task is done on caller side in fs/sysfs/file.c

Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent 753f1583

drivers/power/ds2781_battery.c

+0 −8
Original line number Diff line number Diff line
@@ -639,8 +639,6 @@ static ssize_t ds2781_read_param_eeprom_bin(struct file *filp, 
	struct power_supply *psy = to_power_supply(dev);

	struct ds2781_device_info *dev_info = to_ds2781_device_info(psy);



	count = min_t(loff_t, count, DS2781_PARAM_EEPROM_SIZE - off);



	return ds2781_read_block(dev_info, buf,

				DS2781_EEPROM_BLOCK1_START + off, count);

}
@@ -655,8 +653,6 @@ static ssize_t ds2781_write_param_eeprom_bin(struct file *filp, 
	struct ds2781_device_info *dev_info = to_ds2781_device_info(psy);

	int ret;



	count = min_t(loff_t, count, DS2781_PARAM_EEPROM_SIZE - off);



	ret = ds2781_write(dev_info, buf,

				DS2781_EEPROM_BLOCK1_START + off, count);

	if (ret < 0)
@@ -688,8 +684,6 @@ static ssize_t ds2781_read_user_eeprom_bin(struct file *filp, 
	struct power_supply *psy = to_power_supply(dev);

	struct ds2781_device_info *dev_info = to_ds2781_device_info(psy);



	count = min_t(loff_t, count, DS2781_USER_EEPROM_SIZE - off);



	return ds2781_read_block(dev_info, buf,

				DS2781_EEPROM_BLOCK0_START + off, count);
@@ -705,8 +699,6 @@ static ssize_t ds2781_write_user_eeprom_bin(struct file *filp, 
	struct ds2781_device_info *dev_info = to_ds2781_device_info(psy);

	int ret;



	count = min_t(loff_t, count, DS2781_USER_EEPROM_SIZE - off);



	ret = ds2781_write(dev_info, buf,

				DS2781_EEPROM_BLOCK0_START + off, count);

	if (ret < 0)