Commit 36628731 authored Oct 23, 2012 by Ezequiel Garcia Committed by Mauro Carvalho Chehab Dec 27, 2012

[media] tuners/xc4000: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent f01e0ffd

drivers/media/tuners/xc4000.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1066,7 +1066,7 @@ static int check_firmware(struct dvb_frontend *fe, unsigned int type,
	goto fail;		goto fail;
	}		}

	memcpy(&priv->cur_fw, &new_fw, sizeof(priv->cur_fw));		priv->cur_fw = new_fw;

	/*		/*
	* By setting BASE in cur_fw.type only after successfully loading all		* By setting BASE in cur_fw.type only after successfully loading all