Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 33b3a561 authored by Kim, Milo's avatar Kim, Milo Committed by Bryan Wu
Browse files

leds: support new LP8501 device - another LP55xx common 



LP8501 can drive up to 9 channels like LP5523.
LEDs can be controlled directly via the I2C and programmable engines are
supported.

LP55xx common driver
 LP8501 is one of LP55xx family device, so LP55xx common code are used.
 Chip specific data is defined in the structure, 'lp55xx_device_config'.

Differences between LP8501 and LP5523
 Different register layout for LED output control and others.
 LP8501 specific feature for separate output power selection.
 LP8501 doesn't support external clock detection.
 Different programming engine data.

LP8501 specific feature - output power selection
 Output channels are selected by power selection - Vout or Vdd.
 Separate power for VDD1-6 and VDD7-9 are available.
 It is configurable in the platform data.
 To support this feature, LP55xx DT structure and header are changed.
 Device tree binding is updated as well.

LED pattern data
 Example pattern data is updated in the driver documentation.

Signed-off-by: default avatarMilo Kim <milo.kim@ti.com>
Signed-off-by: default avatarBryan Wu <cooloney@gmail.com>
parent 81d22878

Documentation/devicetree/bindings/leds/leds-lp55xx.txt

+71 −1
Original line number Diff line number Diff line 
Binding for TI/National Semiconductor LP55xx Led Drivers



Required properties:

- compatible: "national,lp5521" or "national,lp5523" or "ti,lp5562"

- compatible: "national,lp5521" or "national,lp5523" or "ti,lp5562" or "ti,lp8501"

- reg: I2C slave address

- clock-mode: Input clock mode, (0: automode, 1: internal, 2: external)
@@ -11,6 +11,11 @@ Each child has own specific current settings 


Optional properties:

- label: Used for naming LEDs

- pwr-sel: LP8501 specific property. Power selection for output channels.

         0: D1~9 are connected to VDD

         1: D1~6 with VDD, D7~9 with VOUT

         2: D1~6 with VOUT, D7~9 with VDD

         3: D1~9 are connected to VOUT



Alternatively, each child can have specific channel name

- chan-name: Name of each channel name
@@ -145,3 +150,68 @@ lp5562@30 { 
		max-cur = /bits/ 8 <0x60>;

	};

};



example 4) LP8501

9 channels are defined. The 'pwr-sel' is LP8501 specific property.

Others are same as LP5523.



lp8501@32 {

	compatible = "ti,lp8501";

	reg = <0x32>;

	clock-mode = /bits/ 8 <2>;

	pwr-sel = /bits/ 8 <3>;	/* D1~9 connected to VOUT */



	chan0 {

		chan-name = "d1";

		led-cur = /bits/ 8 <0x14>;

		max-cur = /bits/ 8 <0x20>;

	};



	chan1 {

		chan-name = "d2";

		led-cur = /bits/ 8 <0x14>;

		max-cur = /bits/ 8 <0x20>;

	};



	chan2 {

		chan-name = "d3";

		led-cur = /bits/ 8 <0x14>;

		max-cur = /bits/ 8 <0x20>;

	};



	chan3 {

		chan-name = "d4";

		led-cur = /bits/ 8 <0x14>;

		max-cur = /bits/ 8 <0x20>;

	};



	chan4 {

		chan-name = "d5";

		led-cur = /bits/ 8 <0x14>;

		max-cur = /bits/ 8 <0x20>;

	};



	chan5 {

		chan-name = "d6";

		led-cur = /bits/ 8 <0x14>;

		max-cur = /bits/ 8 <0x20>;

	};



	chan6 {

		chan-name = "d7";

		led-cur = /bits/ 8 <0x14>;

		max-cur = /bits/ 8 <0x20>;

	};



	chan7 {

		chan-name = "d8";

		led-cur = /bits/ 8 <0x14>;

		max-cur = /bits/ 8 <0x20>;

	};



	chan8 {

		chan-name = "d9";

		led-cur = /bits/ 8 <0x14>;

		max-cur = /bits/ 8 <0x20>;

	};

};

Documentation/leds/leds-lp55xx.txt

+27 −3
Original line number Diff line number Diff line 
LP5521/LP5523/LP55231 Common Driver

===================================

LP5521/LP5523/LP55231/LP5562/LP8501 Common Driver

=================================================



Authors: Milo(Woogyom) Kim <milo.kim@ti.com>



Description

-----------

LP5521, LP5523/55231 and LP5562 have common features as below.

LP5521, LP5523/55231, LP5562 and LP8501 have common features as below.



  Register access via the I2C

  Device initialization/deinitialization
@@ -109,6 +109,30 @@ As soon as 'loading' is set to 0, registered callback is called. 
Inside the callback, the selected engine is loaded and memory is updated.

To run programmed pattern, 'run_engine' attribute should be enabled.



The pattern sqeuence of LP8501 is same as LP5523.

However pattern data is specific.

Ex 1) Engine 1 is used

echo 1 > /sys/bus/i2c/devices/xxxx/select_engine

echo 1 > /sys/class/firmware/lp8501/loading

echo "9d0140ff7e0040007e00a001c000" > /sys/class/firmware/lp8501/data

echo 0 > /sys/class/firmware/lp8501/loading

echo 1 > /sys/bus/i2c/devices/xxxx/run_engine



Ex 2) Engine 2 and 3 are used at the same time

echo 2 > /sys/bus/i2c/devices/xxxx/select_engine

sleep 1

echo 1 > /sys/class/firmware/lp8501/loading

echo "9d0140ff7e0040007e00a001c000" > /sys/class/firmware/lp8501/data

echo 0 > /sys/class/firmware/lp8501/loading

sleep 1

echo 3 > /sys/bus/i2c/devices/xxxx/select_engine

sleep 1

echo 1 > /sys/class/firmware/lp8501/loading

echo "9d0340ff7e0040007e00a001c000" > /sys/class/firmware/lp8501/data

echo 0 > /sys/class/firmware/lp8501/loading

sleep 1

echo 1 > /sys/class/leds/d1/device/run_engine



( 'run_engine' and 'firmware_cb' )

The sequence of running the program data is common.

But each device has own specific register addresses for commands.

drivers/leds/Kconfig

+15 −3
Original line number Diff line number Diff line
@@ -194,11 +194,11 @@ config LEDS_LP3944 
	  module will be called leds-lp3944.



config LEDS_LP55XX_COMMON

	tristate "Common Driver for TI/National LP5521, LP5523/55231 and LP5562"

	depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562

	tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501"

	depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || LEDS_LP8501

	select FW_LOADER

	help

	  This option supports common operations for LP5521 and LP5523/55231

	  This option supports common operations for LP5521/5523/55231/5562/8501

	  devices.



config LEDS_LP5521
@@ -232,6 +232,18 @@ config LEDS_LP5562 
	  Driver provides direct control via LED class and interface for

	  programming the engines.



config LEDS_LP8501

	tristate "LED Support for TI LP8501 LED driver chip"

	depends on LEDS_CLASS && I2C

	select LEDS_LP55XX_COMMON

	help

	  If you say yes here you get support for TI LP8501 LED driver.

	  It is 9 channel chip with programmable engines.

	  Driver provides direct control via LED class and interface for

	  programming the engines.

	  It is similar as LP5523, but output power selection is available.

	  And register layout and engine program schemes are different.



config LEDS_LP8788

	tristate "LED support for the TI LP8788 PMIC"

	depends on LEDS_CLASS

drivers/leds/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ obj-$(CONFIG_LEDS_LP55XX_COMMON) += leds-lp55xx-common.o 
obj-$(CONFIG_LEDS_LP5521)		+= leds-lp5521.o

obj-$(CONFIG_LEDS_LP5523)		+= leds-lp5523.o

obj-$(CONFIG_LEDS_LP5562)		+= leds-lp5562.o

obj-$(CONFIG_LEDS_LP8501)		+= leds-lp8501.o

obj-$(CONFIG_LEDS_LP8788)		+= leds-lp8788.o

obj-$(CONFIG_LEDS_TCA6507)		+= leds-tca6507.o

obj-$(CONFIG_LEDS_CLEVO_MAIL)		+= leds-clevo-mail.o

drivers/leds/leds-lp55xx-common.c

+3 −0
Original line number Diff line number Diff line
@@ -593,6 +593,9 @@ int lp55xx_of_populate_pdata(struct device *dev, struct device_node *np) 
	of_property_read_string(np, "label", &pdata->label);

	of_property_read_u8(np, "clock-mode", &pdata->clock_mode);



	/* LP8501 specific */

	of_property_read_u8(np, "pwr-sel", (u8 *)&pdata->pwr_sel);



	dev->platform_data = pdata;



	return 0;