Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2fca6d28 authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by David S. Miller
Browse files

of_mdio: kill useless variable in of_mdiobus_register() 



of_mdiobus_register()  declares the 'paddr' variable to hold the result of
the of_get_property()  but only uses it once after that while the function
can be called directly from the *if* statement. Remove that variable and
switch to calling of_find_property() instead since  we don't care about
the "reg" property's value anyway...

Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 87f761ec

drivers/of/of_mdio.c

+1 −3
Original line number Diff line number Diff line
@@ -211,7 +211,6 @@ static bool of_mdiobus_child_is_phy(struct device_node *child) 
int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)

{

	struct device_node *child;

	const __be32 *paddr;

	bool scanphys = false;

	int addr, rc;
@@ -246,8 +245,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) 
	/* auto scan for PHYs with empty reg property */

	for_each_available_child_of_node(np, child) {

		/* Skip PHYs with reg property set */

		paddr = of_get_property(child, "reg", NULL);

		if (paddr)

		if (of_find_property(child, "reg", NULL))

			continue;



		for (addr = 0; addr < PHY_MAX_ADDR; addr++) {