Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2dab26f6 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Greg Kroah-Hartman
Browse files

usb: phy: twl6030: add IRQ checks 



[ Upstream commit 0881e22c06e66af0b64773c91c8868ead3d01aa1 ]

The driver neglects to check the result of platform_get_irq()'s calls and
blithely passes the negative error codes to request_threaded_irq() (which
takes *unsigned* IRQ #), causing them both to fail with -EINVAL, overriding
an original error code.  Stop calling request_threaded_irq() with the
invalid IRQ #s.

Fixes: c33fad0c ("usb: otg: Adding twl6030-usb transceiver driver for OMAP4430")
Acked-by: default avatarFelipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/9507f50b-50f1-6dc4-f57c-3ed4e53a1c25@omp.ru


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 23479ea2

drivers/usb/phy/phy-twl6030-usb.c

+5 −0
Original line number Diff line number Diff line
@@ -342,6 +342,11 @@ static int twl6030_usb_probe(struct platform_device *pdev) 
	twl->irq2		= platform_get_irq(pdev, 1);

	twl->linkstat		= MUSB_UNKNOWN;



	if (twl->irq1 < 0)

		return twl->irq1;

	if (twl->irq2 < 0)

		return twl->irq2;



	twl->comparator.set_vbus	= twl6030_set_vbus;

	twl->comparator.start_srp	= twl6030_start_srp;