Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23479ea2 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Greg Kroah-Hartman
Browse files

usb: phy: fsl-usb: add IRQ check 



[ Upstream commit ecc2f30dbb25969908115c81ec23650ed982b004 ]

The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to request_irq() (which takes
*unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original
error code. Stop calling request_irq() with the invalid IRQ #s.

Fixes: 0807c500 ("USB: add Freescale USB OTG Transceiver driver")
Acked-by: default avatarFelipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/b0a86089-8b8b-122e-fd6d-73e8c2304964@omp.ru


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 99a53e69

drivers/usb/phy/phy-fsl-usb.c

+2 −0
Original line number Diff line number Diff line
@@ -873,6 +873,8 @@ int usb_otg_start(struct platform_device *pdev) 


	/* request irq */

	p_otg->irq = platform_get_irq(pdev, 0);

	if (p_otg->irq < 0)

		return p_otg->irq;

	status = request_irq(p_otg->irq, fsl_otg_isr,

				IRQF_SHARED, driver_name, p_otg);

	if (status) {