Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 99a53e69 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Greg Kroah-Hartman
Browse files

usb: gadget: udc: at91: add IRQ check 



[ Upstream commit 50855c31573b02963f0aa2aacfd4ea41c31ae0e0 ]

The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which takes
*unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original
error code. Stop calling devm_request_irq() with the invalid IRQ #s.

Fixes: 8b2e7668 ("USB: AT91 UDC updates, mostly power management")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Acked-by: default avatarFelipe Balbi <balbi@kernel.org>
Link: https://lore.kernel.org/r/6654a224-739a-1a80-12f0-76d920f87b6c@omp.ru


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a94fdd4b

drivers/usb/gadget/udc/at91_udc.c

+3 −1
Original line number Diff line number Diff line
@@ -1879,7 +1879,9 @@ static int at91udc_probe(struct platform_device *pdev) 
	clk_disable(udc->iclk);



	/* request UDC and maybe VBUS irqs */

	udc->udp_irq = platform_get_irq(pdev, 0);

	udc->udp_irq = retval = platform_get_irq(pdev, 0);

	if (retval < 0)

		goto err_unprepare_iclk;

	retval = devm_request_irq(dev, udc->udp_irq, at91_udc_irq, 0,

				  driver_name, udc);

	if (retval) {