Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 298c8545 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Alexandre Belloni
Browse files

rtc: r7301: Fix a possible sleep-in-atomic bug in rtc7301_set_time 



The driver may sleep under a spinlock.
The function call path is:
rtc7301_set_time (acquire the spinlock)
  usleep_range --> may sleep

To fix it, usleep_range is replaced with udelay.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent cd8c0bb2

drivers/rtc/rtc-r7301.c

+1 −1
Original line number Diff line number Diff line
@@ -235,7 +235,7 @@ static int rtc7301_set_time(struct device *dev, struct rtc_time *tm) 
	spin_lock_irqsave(&priv->lock, flags);



	rtc7301_stop(priv);

	usleep_range(200, 300);

	udelay(300);

	rtc7301_select_bank(priv, 0);

	rtc7301_write_time(priv, tm, false);

	rtc7301_start(priv);