Commit cd8c0bb2 authored Dec 13, 2017 by Jia-Ju Bai Committed by Alexandre Belloni Jan 12, 2018

rtc: r7301: Fix a possible sleep-in-atomic bug in rtc7301_read_time



The driver may sleep under a spinlock.
The function call path is:
rtc7301_read_time (acquire the spinlock)
  rtc7301_wait_while_busy
    usleep_range --> may sleep

To fix it, usleep_range is replaced with udelay.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

parent 2da6877f

drivers/rtc/rtc-r7301.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -95,7 +95,7 @@ static int rtc7301_wait_while_busy(struct rtc7301_priv *priv)
		if (!(val & RTC7301_CONTROL_BUSY))
		return 0;

		usleep_range(200, 300);
		udelay(300);
		}

		return -ETIMEDOUT;