Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e60728a authored by Ravikanth Tuniki's avatar Ravikanth Tuniki
Browse files

disp: msm: sde: Fix 32-bit compilation issues 



1.Typecast to avoid distinct pointer type comparison
2.Keep DMA mask aligned with api definition.
3.Add Suffix for literals
4.Remove multfrac func to avoid uncompatible division.
5.64-bit division( operator "/") on 32-bit platforms is not supported.
  Using platform independent API's here

Change-Id: I0e7305418e53876bd1adf00c1963f85cbdf980cc
Signed-off-by: default avatarRavikanth Tuniki <rtunik@codeaurora.org>
parent c5f58d2f

msm/dsi/dsi_ctrl.c

+2 −2
Original line number Diff line number Diff line
@@ -847,8 +847,8 @@ static int dsi_ctrl_update_link_freqs(struct dsi_ctrl *dsi_ctrl, 
		bit_rate = config->bit_clk_rate_hz_override * num_of_lanes;

	} else if (config->panel_mode == DSI_OP_CMD_MODE) {

		/* Calculate the bit rate needed to match dsi transfer time */

		bit_rate = mult_frac(min_dsi_clk_hz, frame_time_us,

				dsi_transfer_time_us);

		bit_rate = min_dsi_clk_hz * frame_time_us;

		do_div(bit_rate, dsi_transfer_time_us);

		bit_rate = bit_rate * num_of_lanes;

	} else {

		h_period = DSI_H_TOTAL_DSC(timing);

msm/dsi/dsi_panel.c

+19 −11
Original line number Diff line number Diff line
@@ -2492,6 +2492,7 @@ static int dsi_panel_parse_phy_timing(struct dsi_display_mode *mode, 
	u32 len, i;

	int rc = 0;

	struct dsi_display_mode_priv_info *priv_info;

	u64 pixel_clk_khz;



	if (!mode || !mode->priv_info)

		return -EINVAL;
@@ -2520,9 +2521,11 @@ static int dsi_panel_parse_phy_timing(struct dsi_display_mode *mode, 
		 *  function dsi_panel_calc_dsi_transfer_time( )

		 *  as we set it based on dsi clock or mdp transfer time.

		 */

		mode->pixel_clk_khz = (DSI_H_TOTAL_DSC(&mode->timing) *

		pixel_clk_khz = (DSI_H_TOTAL_DSC(&mode->timing) *

				DSI_V_TOTAL(&mode->timing) *

				mode->timing.refresh_rate) / 1000;

				mode->timing.refresh_rate);

		do_div(pixel_clk_khz, 1000);

		mode->pixel_clk_khz = pixel_clk_khz;

	}



	return rc;
@@ -3570,7 +3573,8 @@ void dsi_panel_calc_dsi_transfer_time(struct dsi_host_common_cfg *config, 
		struct dsi_display_mode *mode, u32 frame_threshold_us)

{

	u32 frame_time_us,nslices;

	u64 min_bitclk_hz, total_active_pixels, bits_per_line, pclk_rate_hz;

	u64 min_bitclk_hz, total_active_pixels, bits_per_line, pclk_rate_hz,

		dsi_transfer_time_us, pixel_clk_khz;

	struct msm_display_dsc_info *dsc = mode->timing.dsc;

	struct dsi_mode_info *timing = &mode->timing;

	struct dsi_display_mode *display_mode;
@@ -3605,15 +3609,18 @@ void dsi_panel_calc_dsi_transfer_time(struct dsi_host_common_cfg *config, 
					* timing->v_active));

		/* calculate the actual bitclk needed to transfer the frame */

		min_bitclk_hz = (total_active_pixels * (timing->refresh_rate) *

				(config->bpp)) / (config->num_data_lanes);

				(config->bpp));

		do_div(min_bitclk_hz, config->num_data_lanes);

	}



	timing->min_dsi_clk_hz = min_bitclk_hz;



	if (timing->clk_rate_hz) {

		/* adjust the transfer time proportionately for bit clk*/

		timing->dsi_transfer_time_us = mult_frac(frame_time_us,

				min_bitclk_hz, timing->clk_rate_hz);

		dsi_transfer_time_us = frame_time_us * min_bitclk_hz;

		do_div(dsi_transfer_time_us, timing->clk_rate_hz);

		timing->dsi_transfer_time_us = dsi_transfer_time_us;



	} else if (mode->priv_info->mdp_transfer_time_us) {

		timing->dsi_transfer_time_us =

			mode->priv_info->mdp_transfer_time_us;
@@ -3655,13 +3662,14 @@ void dsi_panel_calc_dsi_transfer_time(struct dsi_host_common_cfg *config, 
	}



	/* Calculate pclk_khz to update modeinfo */

	pclk_rate_hz = mult_frac(min_bitclk_hz, frame_time_us,

			timing->dsi_transfer_time_us);

	pclk_rate_hz =  min_bitclk_hz * frame_time_us;

	do_div(pclk_rate_hz, timing->dsi_transfer_time_us);



	display_mode->pixel_clk_khz = mult_frac(pclk_rate_hz,

			config->num_data_lanes, config->bpp);

	pixel_clk_khz = pclk_rate_hz * config->num_data_lanes;

	do_div(pixel_clk_khz, config->bpp);

	display_mode->pixel_clk_khz = pixel_clk_khz;



	do_div(display_mode->pixel_clk_khz, 1000);

	display_mode->pixel_clk_khz =  display_mode->pixel_clk_khz / 1000;

}

msm/dsi/dsi_phy_timing_v4_0.c

+3 −3
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ int32_t dsi_phy_hw_v4_0_calc_clk_zero(s64 rec_temp1, s64 mult) 
	s64 rec_temp2, rec_temp3;



	rec_temp2 = rec_temp1;

	rec_temp3 = roundup(div_s64(rec_temp2, 8), mult);

	rec_temp3 = roundup64(div_s64(rec_temp2, 8), mult);

	return (div_s64(rec_temp3, mult) - 1);

}
@@ -37,7 +37,7 @@ int32_t dsi_phy_hw_v4_0_calc_clk_trail_rec_min(s64 temp_mul, 


	rec_temp1 = temp_mul;

	rec_temp2 = div_s64(rec_temp1, 8);

	rec_temp3 = roundup(rec_temp2, mult);

	rec_temp3 = roundup64(rec_temp2, mult);

	return (div_s64(rec_temp3, mult) - 1);

}
@@ -53,7 +53,7 @@ int32_t dsi_phy_hw_v4_0_calc_hs_zero(s64 temp1, s64 mult) 
{

	s64 rec_temp2, rec_min;



	rec_temp2 = roundup((temp1 / 8), mult);

	rec_temp2 = roundup64((temp1 / 8), mult);

	rec_min = rec_temp2 - (1 * mult);

	return div_s64(rec_min, mult);

}

msm/msm_smmu.c

+1 −1
Original line number Diff line number Diff line
@@ -451,7 +451,7 @@ static int msm_smmu_probe(struct platform_device *pdev) 
		client->dev->dma_parms = devm_kzalloc(client->dev,

				sizeof(*client->dev->dma_parms), GFP_KERNEL);

	dma_set_max_seg_size(client->dev, DMA_BIT_MASK(32));

	dma_set_seg_boundary(client->dev, DMA_BIT_MASK(64));

	dma_set_seg_boundary(client->dev, (unsigned long)DMA_BIT_MASK(64));



	iommu_set_fault_handler(client->domain,

			msm_smmu_fault_handler, (void *)client);

msm/sde/sde_crtc.c

+2 −2
Original line number Diff line number Diff line
@@ -276,7 +276,7 @@ static ssize_t measured_fps_show(struct device *device, 
{

	struct drm_crtc *crtc;

	struct sde_crtc *sde_crtc;

	unsigned int fps_int, fps_decimal;

	uint64_t fps_int, fps_decimal;

	u64 fps = 0, frame_count = 0;

	ktime_t current_time;

	int i = 0, current_time_index;
@@ -353,7 +353,7 @@ static ssize_t measured_fps_show(struct device *device, 
		}

	}



	fps_int = (unsigned int) sde_crtc->fps_info.measured_fps;

	fps_int = (uint64_t) sde_crtc->fps_info.measured_fps;

	fps_decimal = do_div(fps_int, 10);

	return scnprintf(buf, PAGE_SIZE,

	"fps: %d.%d duration:%d frame_count:%lld\n", fps_int, fps_decimal,